BCrypt::Errors::* descend from new BCrypt::Error.#51
Merged
Conversation
This makes error handling far easier, and does not impact backwards
compatibility.
This is now possible:
begin
# some BCrypt call
rescue BCrypt::Error
# handle error
end
Instead of:
begin
# some BCrypt call
rescue BCrypt::Errors::InvalidSalt, BCrypt::Errors::InvalidHash, BCrypt::Errors::InvalidCost, BCrypt::Errors::InvalidSecret
# handle error
end
RSpec output:
Errors
BCrypt::Error
can be rescued as a StandardError
BCrypt::Errors::InvalidCost
can be rescued as a BCrypt::Error
BCrypt::Errors::InvalidHash
can be rescued as a BCrypt::Error
BCrypt::Errors::InvalidSalt
can be rescued as a BCrypt::Error
BCrypt::Errors::InvalidSecret
can be rescued as a BCrypt::Error
tmm1
added a commit
that referenced
this pull request
Mar 31, 2013
BCrypt::Errors::* descend from new BCrypt::Error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of a root BCrypt::Error class makes error handling far less verbose, and does not impact backwards compatibility. It also means code which rescues
BCrypt::Errortoday will handleBCrypt::Errors::InvalidMoonPhaseif it's added in future.Before
After
RSpec output: