Collect test executionProperties once#29244
Closed
katre wants to merge 2 commits intobazelbuild:masterfrom
Closed
Conversation
TestTargetProperties. This prevents repeatedly merging the same maps when the same test is run multiple times (either due to `flaky = True` or `--runs_per_test`). RELNOTES: None.
gregestren
reviewed
Apr 7, 2026
|
|
||
| @Override | ||
| public ImmutableMap<String, String> getExecutionInfo() { | ||
| return mergeMaps(super.getExecutionInfo(), testProperties.getExecutionInfo()); |
Contributor
There was a problem hiding this comment.
actionOwner.getExecProperties() resolves to the same?
Collaborator
Author
There was a problem hiding this comment.
Yes, that's the ultimate source of the data. It's tricky to trace, unfortunately (hence a lot of debugging). Hopefully this is a bit simpler to watch.
Collaborator
Author
There was a problem hiding this comment.
Any further comments?
gregestren
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store them in the TestTargetProperties.
This prevents repeatedly merging the same maps when the same test is run multiple times (either due to
flaky = Trueor--runs_per_test).RELNOTES: None.