fix(run): clarify sharded test errors with --script_path#29190
Open
abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
Open
fix(run): clarify sharded test errors with --script_path#29190abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
|
This fixes #16193 by making the sharded-test error clearer when Previously, the error did not clearly explain that the limitation was specific to This change:
This is a clarity/documentation fix only. It does not change the underlying behavior of |
Contributor
Author
|
Thanks — this PR does not change run behavior. It only makes the sharded-test failure clearer in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16193.
Summary
This change improves the clarity of the error message shown when running sharded tests with bazel run in --script_path mode.
Previously, the error message did not explicitly indicate that the limitation was specific to --script_path, which could make it unclear why sharded tests or --runs_per_test were rejected in this context.
This change:
updates the error message to explicitly mention --script_path when that mode is active
documents the sharding and --runs_per_test limitation in the corresponding flag help text
adds focused unit tests to verify the correct error message is selected
This is a user-facing clarity improvement only and does not change the underlying behavior of bazel run.
Testing
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer bazel test
//src/test/java/com/google/devtools/build/lib/runtime:RunCommandTest
//src/test/java/com/google/devtools/build/lib/runtime:RunCommandLineTest