Skip to content

Use 'os' instead of 'ioutil' in gazelle tests - #962

Merged
groodt merged 1 commit into
bazel-contrib:mainfrom
aignas:ioutil-remove
Jan 2, 2023
Merged

Use 'os' instead of 'ioutil' in gazelle tests#962
groodt merged 1 commit into
bazel-contrib:mainfrom
aignas:ioutil-remove

Conversation

@aignas

@aignas aignas commented Jan 2, 2023

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

We are currently using ioutil.ReadFile in gazelle tests even though it has been deprecated since 1.16 as per official docs.

What is the new behavior?

Use os.ReadFile instead as the package suggests.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@aignas
aignas requested a review from f0rmiga as a code owner January 2, 2023 12:02

@groodt groodt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt
groodt merged commit 9022291 into bazel-contrib:main Jan 2, 2023
@aignas
aignas deleted the ioutil-remove branch February 13, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants