Refactor and separate concerns of external python package handling code - #953
Merged
Conversation
rickeylev
approved these changes
Jan 10, 2023
rickeylev
left a comment
Collaborator
There was a problem hiding this comment.
Just nits, really; otherwise LGTM
| @@ -0,0 +1,51 @@ | |||
| load("@rules_python//python:defs.bzl", "py_binary", "py_library", "py_test") | |||
Collaborator
There was a problem hiding this comment.
Should this be "@rules_python//" or just "//"?
| srcs = [ | ||
| "namespace_pkgs_test.py", | ||
| ], | ||
| tags = ["unit"], |
Collaborator
There was a problem hiding this comment.
Is this tags=unit used by something elsewhere (didn't see it)? I'd think that size=small was sufficient info to filter (small usually means unit test)
Contributor
Author
There was a problem hiding this comment.
I think it's probably unused. I saw a few test_tag_filters to exclude integration test tags. I'll try remove it and see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the code that deals with external python packages retrieved from repositories (i.e. PyPI, artifactory etc) into 3 main concerns:
requirements.bzllock file for the external python packages from a fully resolvedrequirements.txtfile (optionally generated from dependency_resolver. See 3)requirements.infile of direct dependencies into arequirements.txtfile.I think the refactor makes the code easier to work with and understand. This should make further improvements easier over time.