Fix misleading error message - #927
Merged
Merged
Conversation
When `rctx.which` can not find a program for the specified name, it returns `None`. We should not override the original `python_interpreter` in this case, otherwise we'll see a misleading error message like `Error in fail: python interpreter `None` not found in PATH`
suzaku
force-pushed
the
fix-error-message
branch
from
December 9, 2022 06:54
009e121 to
a4b15f7
Compare
rickeylev
approved these changes
Jan 20, 2023
rickeylev
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for improving this error message! I ran into this when I was first getting started and it did leave me a bit perplexed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
rctx.whichcan not find a program for the specified name, it returnsNone.We should not override the original
python_interpreterin this case, otherwise we'll see a misleading error message likeError in fail: python interpreter `None` not found in PATHPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information