fix: don't test on release - #920
Merged
Merged
Conversation
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Member
Author
|
It's unacceptable to have it fail later during release after the main CI is green: https://github.com/bazelbuild/rules_python/actions/runs/3633627502/jobs/6130855808. |
Collaborator
What test run is this referring to? The release steps in the DEVELOPING.md doc doesn't mention anything about pre-testing steps? |
Member
Author
|
We are only pushing tags to a commit on origin/main. The main CI already runs on all commits landed on main. |
rickeylev
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tags that are released already have a more comprehensive test run attached to them, so we don't need to spend a lot of time re-testing on GitHub Actions during release.