Skip to content

Fail if Python 2 values are specified - #887

Merged
rickeylev merged 6 commits into
bazel-contrib:mainfrom
rickeylev:fail-py2
Dec 1, 2022
Merged

Fail if Python 2 values are specified#887
rickeylev merged 6 commits into
bazel-contrib:mainfrom
rickeylev:fail-py2

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Python 2 usages of the rules will immediately fail. Examples include:

py_binary(..., python_version="PY2")
py_library(..., srcs_version="PY2")
py_runtime_pair(..., py2_runtime="//something")

@rickeylev
rickeylev requested a review from groodt November 18, 2022 19:44

@groodt groodt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f0rmiga

f0rmiga commented Dec 1, 2022

Copy link
Copy Markdown
Member

@rickeylev could you resolve the conflicts, please? I'd like to merge this for the next minor release.

Regnerate docs from main
@rickeylev

Copy link
Copy Markdown
Collaborator Author

Well, I had intended to merge in January as part of the new year, but...Yeah, lets just do it now. Worst case we find out sooner and can just revert it.

@f0rmiga

f0rmiga commented Dec 1, 2022

Copy link
Copy Markdown
Member

All good if you want to wait a bit more.

@rickeylev
rickeylev merged commit ce977e1 into bazel-contrib:main Dec 1, 2022
@rickeylev rickeylev mentioned this pull request Dec 1, 2022
3 tasks
@rickeylev
rickeylev deleted the fail-py2 branch December 1, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants