Various updates build_file_generation example - #869
Merged
Conversation
chrislovecnm
force-pushed
the
example-updates
branch
3 times, most recently
from
October 27, 2022 19:09
6099634 to
a80dc3c
Compare
chrislovecnm
force-pushed
the
example-updates
branch
from
December 6, 2022 18:53
e109334 to
38b355d
Compare
chrislovecnm
marked this pull request as ready for review
December 6, 2022 18:56
chrislovecnm
marked this pull request as draft
December 6, 2022 18:57
chrislovecnm
marked this pull request as ready for review
December 6, 2022 19:01
chrislovecnm
force-pushed
the
example-updates
branch
2 times, most recently
from
December 6, 2022 21:18
be0739e to
bc9c36f
Compare
Contributor
Author
|
@alexeagle @f0rmiga @rickeylev PTAL |
chrislovecnm
force-pushed
the
example-updates
branch
2 times, most recently
from
December 6, 2022 21:35
6201f9b to
47a04ae
Compare
f0rmiga
previously requested changes
Dec 7, 2022
Contributor
Author
|
@f0rmiga I have made the updates you requested and reformatted the example code. I am hitting a weird thing though. $ bazel run //:gazelle -- update
INFO: Analyzed target //:gazelle (1 packages loaded, 2 targets configured).
INFO: Found 1 target...
Target //:gazelle up-to-date:
bazel-bin/gazelle-runner.bash
bazel-bin/gazelle
INFO: Elapsed time: 3.373s, Critical Path: 0.04s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Build completed successfully, 1 total action
gazelle: ERROR: failed to validate dependencies for target "@build_file_generation_example//random_number_generator:random_number_generator_test": "generate_random_number" at line 16 from "random_number_generator/__test__.py" is an invalid dependency: possible solutions:
1. Add it as a dependency in the requirements.txt file.
2. Instruct Gazelle to resolve to a known dependency using the gazelle:resolve directive.
3. Ignore it with a comment '# gazelle:ignore generate_random_number' in the Python fileBut unit test will run and is working fine. The dependencies are not wrong. Thoughts? |
Member
|
Add an |
Contributor
Author
This is not working. Let me know if you have any ideas. |
Updating the WORKSPACE file and BUILD file inline documentation. Added new code and new directories for example. Added new unit test for example. Added license headers.
chrislovecnm
force-pushed
the
example-updates
branch
from
December 19, 2022 16:44
14dff43 to
b13e4cd
Compare
- updating gazelle version to 0.28 - updating go version to 1.19.4
- added requirements_windows.txt from running //:requirements.update on windows - modified WORKSPACE and BUILD files to include different requirements.update when running the build on Windows
chrislovecnm
force-pushed
the
example-updates
branch
from
December 19, 2022 18:33
ec32d7c to
9adbc08
Compare
chrislovecnm
commented
Dec 21, 2022
|
|
||
| @generated by rules_python pip_parse repository rule | ||
| from //:requirements.txt | ||
| from @//:requirements.txt |
Contributor
Author
There was a problem hiding this comment.
I had to do update this to get CI to pass
Contributor
There was a problem hiding this comment.
That is spooky that our CI uses a floating version of bazel rather than what's pinned in our .bazelversion file - I think we ought to fix that along with updating that golden file.
alexeagle
approved these changes
Dec 21, 2022
Contributor
Author
|
@alexeagle this got log jammed on @f0rmiga review which I addressed. Any ideas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers various updates and addition to the example. I am writing a python tutorial much like the go tutorial.
Updating the WORKSPACE file and BUILD file inline documentation.
Added new source code
Added new unit test