Move construction of the METADATA file from wheelmaker to .bzl - #844
Merged
Conversation
…ion) from wheelmaker to .bzl to avoid passing possibly unicode data on the commandline, which causes issues on windows an RBE due to UTF-16 vs UTF-8 confusion. Also fix some wrong attribute descriptions.
pstradomski
marked this pull request as ready for review
October 1, 2022 17:31
pstradomski
requested review from
brandjon,
lberki and
thundergolfer
as code owners
October 1, 2022 17:31
pstradomski
requested review from
alexeagle and
groodt
and removed request for
brandjon,
lberki and
thundergolfer
October 1, 2022 17:31
f0rmiga
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move construction of the METADATA (except appending description) file from wheelmaker to .bzl to avoid passing possibly unicode data on the commandline, which causes issues on windows an RBE due to UTF-16 vs UTF-8 confusion.
Also fix some wrong attribute descriptions.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Wheels built on windows or RBE have mangled unicode data
What is the new behavior?
Wheels built on windows or RBE are identical to those created on other unixes.
Does this PR introduce a breaking change?
Other information