feat: cc_import for libpython - #727
Merged
Merged
Conversation
f0rmiga
requested review from
alexeagle
and removed request for
brandjon and
lberki
June 10, 2022 21:24
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
force-pushed
the
f0rmiga/libpython
branch
from
June 10, 2022 21:25
f157e85 to
b02f839
Compare
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
UebelAndre
reviewed
Jun 10, 2022
Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes a
cc_importtarget for libpython. So far, we've only been exposing the headers but on hermetic environments without libpython being found in the system search paths, we need to expose those libraries too.