Expose defs.bzl form resolved_interpreter_os_alias as a target - #659
Merged
Conversation
UebelAndre
marked this pull request as ready for review
March 15, 2022 23:57
Contributor
|
Yup looks right, same reasoning as https://github.com/bazelbuild/rules_python/blob/1b5900297a45b504276f30d64a881e1e7edb8474/python/pip_install/pip_repository.bzl#L118-L119 |
alexeagle
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This broke my
stardoctargets when I went to plug in the new toolchains topip_parsesince I have all that in macros that are called by other repositories.Issue Number: N/A
What is the new behavior?
This allows users to access
{name}_resolved_interpreter//:defs.bzlas a target sostardoccan successfully generate documentation.Does this PR introduce a breaking change?
Other information