fix: take custom tools versions into account when selecting Python interpreter - #654
Merged
Conversation
mattem
force-pushed
the
fix/custom_tools_versions
branch
3 times, most recently
from
March 14, 2022 15:48
7cbdbc4 to
0bca106
Compare
mattem
marked this pull request as ready for review
March 14, 2022 15:53
alexeagle
approved these changes
Mar 14, 2022
| mandatory = True, | ||
| values = TOOL_VERSIONS.keys() + MINOR_MAPPING.keys(), | ||
| ), | ||
| "release_filename": attr.string( |
Contributor
There was a problem hiding this comment.
hmm it's smelly there's no docs/ change in this PR, something must not be wired up
Contributor
Author
There was a problem hiding this comment.
I don't think this is exported, the macro wrapping it is, and these attrs are set in the macro
mattem
force-pushed
the
fix/custom_tools_versions
branch
from
March 15, 2022 13:55
0bca106 to
063d48a
Compare
Contributor
Author
|
Updated to include the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When providing a custom dict for the
tool_versions, take this into account when selecting the filename and url.This also changes the
get_release_urlfunction to allow for different URLs for each platform (where a platform is added after the initial release of the interpreter version).