Skip to content

Fix broken pre-commit hook - #590

Merged
alexeagle merged 1 commit into
bazel-contrib:mainfrom
UebelAndre:cleanup
Dec 29, 2021
Merged

Fix broken pre-commit hook#590
alexeagle merged 1 commit into
bazel-contrib:mainfrom
UebelAndre:cleanup

Conversation

@UebelAndre

@UebelAndre UebelAndre commented Dec 29, 2021

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?
Fixed broken pre-commit hook

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #583

What is the new behavior?

In #583, the commit hooks were added but they were fighting each other. This change fixes it so they don't both always fail.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alexeagle
alexeagle merged commit 356407d into bazel-contrib:main Dec 29, 2021
@UebelAndre
UebelAndre deleted the cleanup branch December 29, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants