Skip to content

Remove forgotten fragments of pip_import rule. #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hrfuller merged 3 commits into from
Dec 31, 2021
Merged

Remove forgotten fragments of pip_import rule. #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e03f345
Remove forgotten fragments of `pip_import` rule.
UebelAndre Dec 29, 2021
4c7da48
Merge branch 'main' into legacy
UebelAndre Dec 29, 2021
a10d5d0
Merge branch 'main' into legacy
UebelAndre Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
/python/ @brandjon @lberki
# But not everything under python/ is the core Python rules.
/python/pip.bzl @thundergolfer @andyscott
/python/whl.bzl @thundergolfer @andyscott
/python/requirements.txt @thundergolfer @andyscott

# Directory containing the Gazelle extension and Go code.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ fully migrated to Starlark code.

Practically, this means that a Bazel team member should approve any PR
concerning the core Python logic. This includes everything under the `python/`
directory except for `pip.bzl`, `whl.bzl`, and `requirements.txt`.
directory except for `pip.bzl` and `requirements.txt`.

Issues should be triaged as follows:

Expand Down
11 changes: 0 additions & 11 deletions docs/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ _DOCS = {
"packaging": "//docs:packaging-docs",
"pip": "//docs:pip-docs",
"python": "//docs:core-docs",
"whl": "//docs:whl-docs",
}

# We define these bzl_library targets here rather than in the //python package
Expand Down Expand Up @@ -86,10 +85,6 @@ stardoc(
deps = [":defs"],
)

# TODO: Consider merging documentation pages for whl and pip. This would
# require re-exporting their symbols from a common .bzl; see
# https://github.com/bazelbuild/skydoc/issues/208.

stardoc(
name = "pip-docs",
out = "pip.md_",
Expand All @@ -101,12 +96,6 @@ stardoc(
],
)

stardoc(
name = "whl-docs",
out = "whl.md_",
input = "//python:whl.bzl",
)

stardoc(
name = "packaging-docs",
out = "packaging.md_",
Expand Down
40 changes: 0 additions & 40 deletions docs/whl.md
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions python/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ filegroup(
"defs.bzl",
"packaging.bzl",
"pip.bzl",
"whl.bzl",
"//python/private:bzl",
],
visibility = ["//:__pkg__"],
Expand Down Expand Up @@ -135,5 +134,4 @@ alias(
exports_files([
"packaging.bzl",
"pip.bzl",
"whl.bzl",
])
83 changes: 0 additions & 83 deletions python/whl.bzl
View file
Open in desktop

This file was deleted.