Simplify release - #587
Merged
Merged
Conversation
alexeagle
force-pushed
the
release2
branch
2 times, most recently
from
December 29, 2021 01:03
3d74b2c to
c6d4e0c
Compare
Instead of building our own .tgz file with release artifacts, just let GitHub do it. Makes the release instructions much quicker, and doesn't require a review pass for releases, so we'll do them more frequently. fixes bazel-contrib#586
hrfuller
approved these changes
Dec 31, 2021
hrfuller
left a comment
Contributor
There was a problem hiding this comment.
This is great. Should we cut a release after this merges to make sure it works? :)
| pass | ||
| for command in config['bazelCommands']: | ||
| bazel_args = command.split(' ') | ||
| bazel_args.append("--override_repository=rules_python=%s/rules_python" % os.environ['TEST_SRCDIR']) |
| bazel_args.append("--override_repository=rules_python=%s/rules_python" % os.environ['TEST_SRCDIR']) | ||
|
|
||
| # Bazel's wrapper script needs this or you get | ||
| # Bazel's wrapper script needs this or you get |
Contributor
Author
|
@hrfuller I'll push a tag to the repo now to verify. |
alexeagle
added a commit
that referenced
this pull request
Aug 8, 2022
Since #587 we just distribute the whole source archive from GitHub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of building our own .tgz file with release artifacts, just let GitHub do it.
Makes the release instructions much quicker, and doesn't require a review pass for releases, so we'll do them more frequently.
Note that GitHub does serve a stable SHA, and automated release notes include the workspace snippet with the SHA.
This produces an archive of 338K that users will fetch. Our previous release was 45K, so this is an order of magnitude larger since our test code, examples, and documentation are now included. However IMO it's not that important, compared with simpler maintenance.
This follows the new example from the rules authors SIG: https://github.com/bazel-contrib/rules-template
fixes #586