Exposed docs for compile_pip_requirements - #534
Merged
Conversation
UebelAndre
requested review from
andyscott,
brandjon,
lberki and
thundergolfer
as code owners
September 14, 2021 18:33
thundergolfer
requested review from
alexeagle
and removed request for
andyscott,
brandjon and
lberki
September 16, 2021 02:10
thundergolfer
left a comment
There was a problem hiding this comment.
Broadly LGTM. Pulls the compile_pip_requirements macro into the main packaging rules namespace, so bringing in @alexeagle to review.
13 tasks
alexeagle
approved these changes
Sep 28, 2021
alexeagle
left a comment
Contributor
There was a problem hiding this comment.
thanks, good time to give the docs some love
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
compile_pip_requirementsis not currently in the docs and seems to otherwise be hidden as a result. This PR fixes that.Issue Number: N/A
What is the new behavior?
compile_pip_requirementscan now be loaded via@rules_python//python:pip.bzlwhich is also used to populatedocs/pip.mdwith the appropriate docs for the rule.Does this PR introduce a breaking change?
Other information