Skip to content

Remove unnecessary import in namespace_pkgs.py - #475

Merged
thundergolfer merged 1 commit into
masterfrom
jonathon--remove-unused-import-25may2021
May 25, 2021
Merged

Remove unnecessary import in namespace_pkgs.py#475
thundergolfer merged 1 commit into
masterfrom
jonathon--remove-unused-import-25may2021

Conversation

@thundergolfer

Copy link
Copy Markdown

See https://github.com/dillon-giacoppo/rules_python_external/pull/54/files for change that removed usage of wheel module.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@google-cla google-cla Bot added the cla: yes label May 25, 2021
@thundergolfer
thundergolfer requested review from hrfuller and removed request for brandjon and lberki May 25, 2021 11:46

@hrfuller hrfuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thundergolfer
thundergolfer merged commit c6970fc into master May 25, 2021
@thundergolfer
thundergolfer deleted the jonathon--remove-unused-import-25may2021 branch June 8, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants