Remove bzl_library from python/pip_install/BUILD so that skylib dep is not exposed to end-users - #430
Merged
Merged
Conversation
…s not exposed to end-users
thundergolfer
requested review from
andyscott,
brandjon and
lberki
as code owners
March 7, 2021 12:19
thundergolfer
requested review from
alexeagle and
hrfuller
and removed request for
brandjon and
lberki
March 7, 2021 12:20
added 3 commits
March 8, 2021 10:58
alexeagle
approved these changes
Mar 8, 2021
Contributor
|
Are there |
Author
|
@UebelAndre Can you elaborate, I'm not sure I know what you mean? Like you would use the |
Contributor
|
Correct, this is similar to what the releases of An example case of consuming that file group can be seen in @rules_rust//docs |
Contributor
|
IMO the best answer is to use the file group in one of the integration tests, as a regression test that our published distro allows that use case. (Separate PR of course) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #372
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #372
What is the new behavior?
/python/pip_install/BUILDno longer has a load statement from@bazel_skylib.I've run
./update_docs.shto check that this doesn't break anything, and it seems fine.Does this PR introduce a breaking change?