Remove obsolete TODO in //distro - #426
Merged
thundergolfer merged 2 commits intoMar 4, 2021
Merged
Conversation
…ase-notes-mar2021
thundergolfer
deleted the
jonathon--remove-TODO-in-distro-about-release-notes-mar2021
branch
March 4, 2021 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧹 🧹 ...
Just removing a TODO we don't need anymore. We not longer use a
deps()function to included dependencies and bazelbuild/rules_pkg#72 shows that it's no longer a desired pattern.PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
cc @brandjon