Skip to content

Remove TODO now that rules_python 0.0.3 (and 0.1.0) have been released - #425

Merged
thundergolfer merged 2 commits into
masterfrom
jonathon--remove-TODO-in-integration-test-file-mar2021
Mar 7, 2021
Merged

Remove TODO now that rules_python 0.0.3 (and 0.1.0) have been released#425
thundergolfer merged 2 commits into
masterfrom
jonathon--remove-TODO-in-integration-test-file-mar2021

Conversation

@thundergolfer

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

🧹🧹...

Just addressing a small TODO.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@thundergolfer
thundergolfer requested a review from andyscott as a code owner March 2, 2021 11:05
@google-cla google-cla Bot added the cla: yes label Mar 2, 2021
@thundergolfer
thundergolfer requested a review from alexeagle March 2, 2021 11:05

@alexeagle alexeagle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@thundergolfer
thundergolfer merged commit e486946 into master Mar 7, 2021
@thundergolfer
thundergolfer deleted the jonathon--remove-TODO-in-integration-test-file-mar2021 branch March 7, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants