agents(rules): add Starlark dict union and Pyrefly PackagePath conventions - #4038
Draft
rickeylev wants to merge 1 commit into
Draft
agents(rules): add Starlark dict union and Pyrefly PackagePath conventions#4038rickeylev wants to merge 1 commit into
rickeylev wants to merge 1 commit into
Conversation
…tions Starlark supports the dictionary union operator (|), making skylib's dicts.add redundant. When using importlib.metadata in Python, f.locate() is typed as PathLike and lacks filesystem methods like .exists() and .is_file() under Pyrefly unless wrapped with pathlib.Path. Add rules instructing agents to prefer the dict union operator (|) over dicts.add in Starlark and to wrap f.locate() calls with pathlib.Path() in Python type-annotated code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starlark supports the dictionary union operator (|), making skylib's
dicts.add redundant. When using importlib.metadata in Python,
f.locate() is typed as PathLike and lacks filesystem methods like
.exists() and .is_file() under Pyrefly unless wrapped with
pathlib.Path.
Add rules instructing agents to prefer the dict union operator (|)
over dicts.add in Starlark and to wrap f.locate() calls with
pathlib.Path() in Python type-annotated code.