rules_python_external integration: drop bazel-mypy-integration - #353
Merged
thundergolfer merged 1 commit intoAug 27, 2020
Conversation
…on into rules_python harder
alexeagle
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing
bazel-mypy-integrationfromexperimental/rules_python_externalas the integration is not required at runtime byrules_python_externaland keeping it in the project will make integration with the 'core' more complicated than necessary.Plan 🛣
Our plan is in multiple steps:
bring in the repo to a subdirectory, preserving git history and contributorsPR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoDoes this PR introduce a breaking change?