refactor: explicitly define host platform ordering - #2890
Merged
aignas merged 19 commits intoMay 20, 2025
Merged
Conversation
rickeylev
force-pushed
the
refactor.well.defined.host.platform.ordering
branch
from
May 16, 2025 23:21
e283fc0 to
b31a9a4
Compare
rickeylev
force-pushed
the
refactor.well.defined.host.platform.ordering
branch
from
May 17, 2025 18:35
b31a9a4 to
f88fc59
Compare
…d.pass.platforms.to.host.repo
Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
…into refactor.bzlmod.pass.platforms.to.host.repo
…into refactor.bzlmod.pass.platforms.to.host.repo
…tor.well.defined.host.platform.ordering
…into refactor.well.defined.host.platform.ordering
rickeylev
commented
May 19, 2025
rickeylev
left a comment
Collaborator
Author
There was a problem hiding this comment.
Ready for PTAL: Dependent PR merged
aignas
reviewed
May 20, 2025
rickeylev
commented
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out the
unsorted-dict-itemsdisable in versions.bzl is load-bearing: theprecedence of what host-compatible runtime is selected depends on the order of keys.
Hence, the keys are carefully defined such that freethreaded and musl come after the
regular runtimes.
Make this subtle and implicit behavior explicit by having an ordering function that
sorts keys in the order we want.
Work towards #2081