refactor: make bzlmod create host repos for toolchains - #2888
Merged
rickeylev merged 2 commits intoMay 19, 2025
Conversation
rickeylev
force-pushed
the
refactor.bzlmod.creates.host.repos
branch
from
May 17, 2025 18:15
1e70b1e to
47b115e
Compare
aignas
approved these changes
May 18, 2025
aignas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I like the host_compatible solution you did here a lot!
aignas
reviewed
May 18, 2025
rickeylev
force-pushed
the
refactor.bzlmod.creates.host.repos
branch
from
May 18, 2025 23:06
47b115e to
56b09f5
Compare
rickeylev
commented
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the creation of the host_toolchain repos into the bzlmod phase.
This is to facilitate future work to allow for when a a particular version
doesn't provide a host-compatible variant
Work towards #2081