refactor: consolidate version parsing - #2874
Merged
rickeylev merged 9 commits intoMay 15, 2025
Merged
Conversation
aignas
force-pushed
the
refactor/remove-many-version-utilities-to-keep-a-single
branch
2 times, most recently
from
May 13, 2025 00:05
fce5cd6 to
b377527
Compare
aignas
force-pushed
the
refactor/remove-many-version-utilities-to-keep-a-single
branch
from
May 14, 2025 23:15
b377527 to
463ffdc
Compare
rickeylev
approved these changes
May 15, 2025
aignas
deleted the
refactor/remove-many-version-utilities-to-keep-a-single
branch
May 15, 2025 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all of the custom version parsing functions where we try
to make sense about the version (e.g. extracting major/minor versions).
Whilst doing this I actually think that I made it easier to support #2837.