refactor: make env marker config available through target and flag - #2853
Merged
Conversation
rickeylev
force-pushed
the
pep508.env.marker.config
branch
from
May 3, 2025 03:40
843b7c8 to
639df2e
Compare
rickeylev
force-pushed
the
pep508.env.marker.config
branch
from
May 3, 2025 03:47
639df2e to
f8b4446
Compare
aignas
reviewed
May 3, 2025
aignas
left a comment
Collaborator
There was a problem hiding this comment.
LGTM in general, we can talk about exposing the EnvMarkerInfo provider in a followup PR that uncomments the docs.
Collaborator
|
Created #2855 to allow enabling the starlark deps paths more easily. |
aignas
reviewed
May 3, 2025
…into pep508.env.marker.config
rickeylev
enabled auto-merge
May 3, 2025 20:33
aignas
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This factors creation of (most of) the env marker dict into a separate target and
provides a label flag to allow customizing the target that provides it.
This makes it easier for users to override how env marker values are computed. The
env_marker_settingrule will still, if necessary, compute values from the toolchain,but existing keys (computed from the env marker config target) have precedence.
The
EnvMarkerInfoprovider is the interface for implementing a custom env markerconfig target; it will be publically exposed in a subsequent PR.
Along the way, unify how the env dict and defaults are set.
Work towards #2826