Skip to content

Upgrade to setuptools==44.0.0 - #285

Merged
lberki merged 2 commits into
bazel-contrib:masterfrom
XingChenKolmostar:master
Mar 3, 2020
Merged

Upgrade to setuptools==44.0.0#285
lberki merged 2 commits into
bazel-contrib:masterfrom
XingChenKolmostar:master

Conversation

@XingChenKolmostar

Copy link
Copy Markdown
Contributor

This allows new features in setuptools, like find_namespace_packages.

This allows new features in setuptools, like find_namespace_packages.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@XingChenKolmostar

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 3, 2020
@lberki

lberki commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Where do these binaries come from? I'm reluctant to merge some random binary blob.

@XingChenKolmostar

XingChenKolmostar commented Mar 3, 2020 via email

Copy link
Copy Markdown
Contributor Author

@lberki

lberki commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Erm, sorry for being somewhat dense. I'll regenerate the binary blobs them and will merge this pull request instead:

#286

@lberki

lberki commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Rebuilt the binaries, checksum matches (see #286). Will merge!

@lberki
lberki removed the request for review from brandjon March 3, 2020 08:59
@lberki
lberki merged commit 17dba4b into bazel-contrib:master Mar 3, 2020
@brandjon

brandjon commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

Thanks Lukács. For reference we always regenerate the par files before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants