Add extra_pip_args option to pip_import - #274
Closed
scarito1 wants to merge 2 commits into
Closed
Conversation
Adds the attr extra_pip_args to pip_import. These args will be passed along to the pip invocation inside piptool.
Merged
brandjon
approved these changes
Feb 21, 2020
brandjon
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just added a comment that the args shouldn't contain whitespace. I'll merge on my end.
gergelyfabian
added a commit
to gergelyfabian/rules_python_external
that referenced
this pull request
May 27, 2020
gergelyfabian
added a commit
to gergelyfabian/rules_python_external
that referenced
this pull request
May 28, 2020
gergelyfabian
added a commit
to gergelyfabian/rules_python_external
that referenced
this pull request
Jun 3, 2020
gergelyfabian
added a commit
to gergelyfabian/rules_python_external
that referenced
this pull request
Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the attr extra_pip_args to pip_import. These args will be passed along to the pip invocation inside piptool. This enables special pip usage such as loading packages from an alternate repository or local directory.