docs: prefer python_version attribute for specifying python version - #2565
docs: prefer python_version attribute for specifying python version#2565JeroenSchmidt wants to merge 4 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks! This looks pretty good overall. I'll send a few comments shortly. Before we can accept the PR, though, you'll need to sign the CLA. https://cla.developers.google.com has instructions as to how. If you have already and the tool is mis-reporting, let me know, and I can force it to rescan. |
rickeylev
left a comment
There was a problem hiding this comment.
A few typo corrections and minor word smithing, otherwise LGTM.
Just waiting for the CLA.
|
Morning @rickeylev I'm waiting for my org to approve the CLA. We have a process in place for CLA approvals. In the meantime Ill finalise the CI failures and open a new PR from my orgs github group once the CLA is approved. |
This goes together with #2565 to remove the internal usage of the deprecated symbols. This also fixes the compile_pip_requirements symbol to print the correct deprecation message. Builds on top of 611eda8 The example message that would be printed is as follows: ``` The 'py_test' symbol in '@+python+python_3_11//:defs.bzl' is deprecated. It is an alias to the regular rule; use it directly instead: load("@rules_python//python:py_test.bzl", "py_test") py_test( name = "versioned_py_test", srcs = ["dummy.py"], main = "dummy.py", python_version = "3.11.11", ) ``` --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com>
|
I got the CLA and ill wrap this up later this week. |
|
Thanks! I think I took care of all of the code and this PR probably only needs to do docs. Thanks for the inspiration. |
This PR is updating the Examples and Docs relating to the recent changes
refactor: fold per-target python version into base rulesintroduced in v.1.1.0.See the brief conversation between myself and @rickeylev in this diff 611eda8