Skip to content

Add a timeout attribute to pip_import rules. #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandjon merged 2 commits into from
Mar 5, 2020
Merged

Add a timeout attribute to pip_import rules. #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6915c78
Add a timeout attribute to pip_import rules.
ChrisCummins Aug 1, 2019
8dd4321
Regenerate documentation
brandjon Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/pip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## pip_import

<pre>
pip_import(<a href="#pip_import-name">name</a>, <a href="#pip_import-extra_pip_args">extra_pip_args</a>, <a href="#pip_import-python_interpreter">python_interpreter</a>, <a href="#pip_import-requirements">requirements</a>)
pip_import(<a href="#pip_import-name">name</a>, <a href="#pip_import-extra_pip_args">extra_pip_args</a>, <a href="#pip_import-python_interpreter">python_interpreter</a>, <a href="#pip_import-requirements">requirements</a>, <a href="#pip_import-timeout">timeout</a>)
</pre>

A rule for importing `requirements.txt` dependencies into Bazel.
Expand Down Expand Up @@ -95,6 +95,15 @@ wheels.
</p>
</td>
</tr>
<tr id="pip_import-timeout">
<td><code>timeout</code></td>
<td>
Integer; optional
<p>
Timeout (in seconds) for repository fetch.
</p>
</td>
</tr>
</tbody>
</table>

Expand Down
6 changes: 5 additions & 1 deletion python/pip.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def _pip_import_impl(repository_ctx):
]

# To see the output, pass: quiet=False
result = repository_ctx.execute(args)
result = repository_ctx.execute(args, timeout=repository_ctx.attr.timeout)

if result.return_code:
fail("pip_import failed: %s (%s)" % (result.stdout, result.stderr))
Expand All @@ -62,6 +62,10 @@ wheels.
allow_single_file = True,
doc = "The label of the requirements.txt file.",
),
"timeout": attr.int(
default = 600,
doc = "Timeout (in seconds) for repository fetch."
),
"_script": attr.label(
executable = True,
default = Label("//tools:piptool.par"),
Expand Down