Rename canonical workspace name to "@rules_python" - #212
Merged
Conversation
This includes regenerating the par files to use the new name. Neat trick: Since
the par file regeneration depends on the previous par files, I had to bootstrap
this change by temporarily editing the WORKSPACE to include:
local_repository(
name = "io_bazel_rules_python",
path = ".",
)
This hooks into pip_repositories(), which users are *supposed* to be calling in their WORKSPACE files, to emit a nice fail() message alerting them that they need to update their repo definition. Without this change (and even with it, for users who do not call `pip_repositories()`), users will instead see a confusing cyclic dependency error.
c-parsons
approved these changes
Jul 26, 2019
|
|
||
| [](https://buildkite.com/bazel/python-rules-python-postsubmit) | ||
|
|
||
| ## Recent updates |
There was a problem hiding this comment.
I'm often a little unclear on whether README.md refers to the most recent release of the repository (and thus should only be updated alongside cutting a new release) or whether it affects state at HEAD. I leave it up to you -- just wanted to make sure you've thought about its role in the release process of rules_python :)
Contributor
Author
There was a problem hiding this comment.
Good point. I don't feel too bad about it being HEAD given that this repo doesn't even have any tags, but I don't know what a general solution would be. Aside from not iterating so quickly on the API. :)
fweikert
pushed a commit
to fweikert/rules_python
that referenced
this pull request
Aug 7, 2019
* Change official workspace name to @rules_python
This includes regenerating the par files to use the new name. Neat trick: Since
the par file regeneration depends on the previous par files, I had to bootstrap
this change by temporarily editing the WORKSPACE to include:
local_repository(
name = "io_bazel_rules_python",
path = ".",
)
* Add a nice error message to help with the workspace name migration
This hooks into pip_repositories(), which users are *supposed* to be calling in
their WORKSPACE files, to emit a nice fail() message alerting them that they
need to update their repo definition.
Without this change (and even with it, for users who do not call
`pip_repositories()`), users will instead see a confusing cyclic dependency
error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203.