feat(whlmaker): introduce an internal _WhlFile class and stop sorting RECORD - #1488
Merged
Merged
Conversation
aignas
force-pushed
the
feat/1076/whlmaker-whlfile
branch
from
October 12, 2023 15:19
fb8909c to
c211655
Compare
Collaborator
Author
|
I would like to merge #1453 and then rebase and merge this. |
Contributor
SGTM |
This class is for being able to more easily recreate a wheel file after extracting it. This is not intended for usage outside the rules_python project. Towards bazel-contrib#1076
aignas
force-pushed
the
feat/1076/whlmaker-whlfile
branch
from
October 17, 2023 05:23
71d508e to
0d2f7f0
Compare
aignas
marked this pull request as ready for review
October 17, 2023 05:24
aignas
enabled auto-merge
October 17, 2023 05:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class is for being able to more easily recreate a wheel file after
extracting it. This is not intended for usage outside the rules_python
project. Also stop sorting the entries when writing a RECORD file making
the order of the RECORD file to be the same as the order the files to
the zip file are added.
Towards #1076