runfiles: Add proper test coverage for an edge case - #1012
Merged
Conversation
Member
Author
|
CC @alexeagle |
The repo mapping wasn't set up correctly to actually test that root symlinks aren't subject to repo mapping.
fmeum
force-pushed
the
test-runfiles-edge-case
branch
from
January 25, 2023 11:54
400fd2b to
3a0afb5
Compare
alexeagle
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The repo mapping wasn't set up correctly to actually test that root symlinks aren't subject to repo mapping.
What is the new behavior?
Does this PR introduce a breaking change?
Other information