Client certificate in git seem buggy - #373
Merged
Merged
Conversation
|
Nice find, @macintux! I'll look at generating some new certs to see if that helps. |
|
Hopefully this batch works better for you: |
|
Looks like basho/riak_api#66 has already been merged in, so I'll need to get #370 fixed before this will successfully build. |
…ient cert authentication
hazen
force-pushed
the
bugfix/bch/update-certs
branch
from
October 1, 2014 22:25
2618807 to
e2b74b9
Compare
|
Worked out that our certificates don't have the CRL location baked into them: https://github.com/basho/riak_api/blob/develop/src/riak_api_ssl.erl#L93. For now switch off checking, but next step will be to add a CRL to the certificate. |
|
👍 e2b74b9 |
borshop
added a commit
that referenced
this pull request
Oct 2, 2014
Client certificate in git seem buggy Reviewed-by: seancribbs
|
@borshop merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certificates generated via the
Makefileinriak/tests/resourcesare fine, but the checked-inclient.crtdoes not validate againstca.crt.server.crtis fine.