This repository was archived by the owner on Aug 13, 2026. It is now read-only.
Adds suport for setting timeouts on PB connections - #151
Closed
tazle wants to merge 6 commits into
Closed
Conversation
added 6 commits
September 24, 2012 14:08
…lass through static method on RiakPbcTransport
- with_timeout now copies options of Socket and adds to the copy, rather than ignoring any options already set
|
This will be obsoleted by #179, but thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150 without API changes. For completeness, similar changes should probably also be added to HTTP side of things.
Does not currently include tests for new behaviour. I'm willing to write tests if somebody advices me on how to get Riak to delay responding to a query so that the timeout is guaranteed to fire.