Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

Fix RiakNode.Builder:setMaxConnections(0), clean up RiakNodeTest.java - #582

Merged
alexmoore merged 2 commits into
developfrom
CLIENTS-685
Feb 2, 2016
Merged

Fix RiakNode.Builder:setMaxConnections(0), clean up RiakNodeTest.java#582
alexmoore merged 2 commits into
developfrom
CLIENTS-685

Conversation

@alexmoore

@alexmoore alexmoore commented Dec 14, 2015

Copy link
Copy Markdown
Contributor

Addresses issue #580 (CLIENTS-685)

Add ability to set MaxConnections explicitly to 0 (unlimited), and cleanup the RiakNodeTest.java file a bit.

Add note about recommended minConnections. Wont' change the minConnections setting now, since it would break people's code that have maxConnections = 1 or 2.

@hazen

hazen commented Dec 15, 2015

Copy link
Copy Markdown

I saw 1 test failure, but is probably unrelated:

Tests run: 5, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 0.021 sec <<< FAILURE!
testSystemDefaultCharsetIsReturnedIfNoPropertyIsDefined(com.basho.riak.client.core.util.DefaultCharsetTest)  Time elapsed: 0.008 sec  <<< FAILURE!
junit.framework.ComparisonFailure: expected:<U[TF-8]> but was:<U[S-ASCII]>
    at junit.framework.Assert.assertEquals(Assert.java:85)
    at junit.framework.Assert.assertEquals(Assert.java:91)
    at com.basho.riak.client.core.util.DefaultCharsetTest.testSystemDefaultCharsetIsReturnedIfNoPropertyIsDefined(DefaultCharsetTest.java:41)

@alexmoore

alexmoore commented Dec 15, 2015

Copy link
Copy Markdown
Contributor Author

Yeah, that's completely unrelated. Need to figure out what went on with your test env, but that can wait until later.

@alexmoore

alexmoore commented Dec 15, 2015

Copy link
Copy Markdown
Contributor Author

Ahh, your tests ran out of order. Not an issue with the code, will make the test cleanup better.

@christophermancini

christophermancini commented Dec 15, 2015

Copy link
Copy Markdown

👍 tests pass, code looks good.

alexmoore added a commit that referenced this pull request Feb 2, 2016
@alexmoore
Merge pull request #582 from basho/CLIENTS-685
6b608cd 
Fix RiakNode.Builder:setMaxConnections(0), clean up RiakNodeTest.java
@alexmoore
alexmoore merged commit 6b608cd into develop Feb 2, 2016
@alexmoore
alexmoore deleted the CLIENTS-685 branch February 2, 2016 19:33
@alexmoore alexmoore mentioned this pull request Feb 9, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexmoore @hazen @christophermancini @srgg