Skip to content

Node-package integration to build debs and rpms#145

Merged
kuenishi merged 10 commits into
masterfrom
ku-node-package-rebased
Nov 10, 2014
Merged

Node-package integration to build debs and rpms#145
kuenishi merged 10 commits into
masterfrom
ku-node-package-rebased

Conversation

@kuenishi

@kuenishi kuenishi commented Nov 6, 2014

Copy link
Copy Markdown
Contributor

Node package requires the latest version tagged on github, so I'd like to tag this as 0.10.0 once this is merged. The number comes from latest version number in basho_bench.app.src.

James Martin and others added 7 commits November 5, 2014 17:35
Through the effort to make smaller package, several changes to the
code and dependent modules were done:

- dependent modules updated; lager, mochiweb and getopt
- some dependent modules removed; erlcql, velvet, casbench
- deprecate R15

Andalso, there are some kludge to enable package install with node_package;

- not using escriptize but just a proxy script installed
- unnecessary directories like log, data created
- unnecessary user and group named basho-bench created for this
- not pinning dependent module versions yet
@kuenishi kuenishi changed the title Node-package integration to build debs and rims Node-package integration to build debs and rpms Nov 6, 2014
@kuenishi

kuenishi commented Nov 6, 2014

Copy link
Copy Markdown
Contributor Author

I'll add R scripts and goodies for graphing like priv/gp_latencies.sh after this merged.

@slfritchie

Copy link
Copy Markdown
Contributor

Kota, can you fix up the 02da072 to avoid touching the Cassandra drivers?

@kuenishi

kuenishi commented Nov 6, 2014

Copy link
Copy Markdown
Contributor Author

@slfritchie Some dependent modules of Cassandra drivers (lz4) screwed up packaging, but I can do that. I just doubted that we really need Cassandra driver or not.

@kuenishi

kuenishi commented Nov 6, 2014

Copy link
Copy Markdown
Contributor Author

I'll try it later!

lz4 and snappy does not have any tags, and that had confused `git describe`.
This version still have following problems:

- Current directory set to /var/lib/basho_bench
  When dpkg-installed basho_bench try tor start, its current directory is
  set as somewhere like /var/lib/basho_bench/lib/basho_bench-*. That is
  where the basho_bench script runs `cd` inside, because just to load
  correct beam files to run whole basho_bench.
  The workaround is to just specify `-d` option with absolute path.

- Currently basho_bench has limited number of example configs installed in
  /etc/basho_bench. It should be installed in other place like
  `/usr/share/basho_bench/examples` but node_package seems not supporting
  such installation other than manpages.
@kuenishi

kuenishi commented Nov 7, 2014

Copy link
Copy Markdown
Contributor Author

From my commit log:

lz4 and snappy does not have any tags, and that had confused git describe.
This version still have following problems:

  • Current directory set to /var/lib/basho_bench
    When dpkg-installed basho_bench try tor start, its current directory is
    set as somewhere like /var/lib/basho_bench/lib/basho_bench-*. That is
    where the basho_bench script runs cd inside, because just to load
    correct beam files to run whole basho_bench.
    The workaround is to just specify -d option with absolute path.

@kuenishi

Copy link
Copy Markdown
Contributor Author

Here, it's ready for review again. Just a kind reminder.

@slfritchie

Copy link
Copy Markdown
Contributor

Hi, sorry about the delay, Kota.

Is the addition of the require_otp_vsn attribute in rebar.config intentional? If I remove that attribute, I can build with R15B03.

@slfritchie

Copy link
Copy Markdown
Contributor

+1 to everything else.

kuenishi added a commit that referenced this pull request Nov 10, 2014
Node-package integration to build debs and rpms
@kuenishi kuenishi merged commit dcbe3ad into master Nov 10, 2014
@kuenishi kuenishi deleted the ku-node-package-rebased branch November 10, 2014 10:17
@kuenishi

Copy link
Copy Markdown
Contributor Author

Thank you for review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants