Feature/bacnet lighting command event callback#1376
Merged
Conversation
… related functions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new “lighting command event” callback mechanism to the BACnet lighting command engine, and extends the existing Zephyr-based unit test to validate that event notifications fire with expected operation/parameter values.
Changes:
- Introduces
lighting_command_event_callbackplus event notification list support (Event_Notification_Head, add/set APIs). - Emits event notifications from lighting operations (fade, ramp, step, warn blink, stop/none, restore/default/toggles).
- Updates the lighting command unit test to assert event notifications and fixes a timer-notification API typo in the test (and header).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/bacnet/basic/sys/lighting_command/src/main.c |
Adds test-side event callback tracking/assertions; updates timer notification add call spelling. |
src/bacnet/basic/sys/lighting_command.h |
Adds event callback types/APIs and a new event notification head in the public data struct; renames timer notification API. |
src/bacnet/basic/sys/lighting_command.c |
Implements event notification list/add/set and emits notifications from lighting command operations. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.