Fix DoS vulnerability in rpm_decode_object_property for malformed RPM requests#1374
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a denial-of-service condition in the ReadPropertyMultiple (RPM) request handling path by ensuring rpm_decode_object_property() returns a negative error when invoked with an exhausted buffer, preventing an infinite loop in handler_read_property_multiple on malformed/truncated requests.
Changes:
- Update
rpm_decode_object_property()to reject calls whereapdu == NULLorapdu_size == 0(returningBACNET_STATUS_REJECTand setting an appropriate reject error code). - Add a regression test that constructs an RPM request missing the closing tag and asserts the decoder returns a negative error once the buffer is exhausted.
- Register the new regression test in the RPM test suite (legacy ztest API path).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/bacnet/rpm.c |
Prevents zero-length decode from returning 0, eliminating the infinite-loop/CPU spin condition on malformed RPM requests. |
test/bacnet/rpm/src/main.c |
Adds/ registers a regression test covering the malformed RPM “missing closing tag” scenario to prevent reintroduction of the DoS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.