Validate ReadRange service request#1303
Open
nathiyaramasamy wants to merge 12 commits into
Open
Conversation
Added a new function to validate ReadRange request parameters.
skarg
reviewed
Apr 19, 2026
| return apdu_len; | ||
| } | ||
|
|
||
| void Validate_RR_parameters() |
Collaborator
There was a problem hiding this comment.
Public basic service handler functions for ReadRange use the prefix handler_read_range.
Suggest to rename to handler_read_range_parameter_validate(void) or perhaps a common function could reside in readrange.c module.
Collaborator
Author
There was a problem hiding this comment.
I will move it to a common function in readrange.c
Added validation for missing mandatory parameters in Read Range request.
Removed empty Validate_RR_parameters function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new function to validate ReadRange request parameters.