Merged
Conversation
liuxingbaoyu
commented
Mar 29, 2026
Member
Author
There was a problem hiding this comment.
These were removed in Babel 8, they no longer exist in the release because we remove them during make prepublish-build.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61274 |
liuxingbaoyu
commented
Mar 29, 2026
| "@babel/cli": "next", | ||
| "@babel/core": "next", | ||
| "@babel/cli": "8.0.0-rc.3", | ||
| "@babel/core": "8.0.0-rc.3", |
Member
Author
There was a problem hiding this comment.
This change is to make it easier for us to avoid using different versions of the package when bumping the baseline package in benchmark.
|
commit: |
JLHwung
approved these changes
Mar 31, 2026
JLHwung
reviewed
Apr 2, 2026
| 2 | ||
| ) | ||
| ); | ||
| } catch {} |
Contributor
There was a problem hiding this comment.
Q: Why do we need the new cleanup here now?
Member
Author
There was a problem hiding this comment.
When we remove helpers, the automatically generated files in @babel/runtime are not removed synchronously until we run make prepublish-build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2