Enable strictFunctionTypes for @babel/types#17906
Merged
JLHwung merged 2 commits intobabel:mainfrom Apr 16, 2026
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61266 |
|
commit: |
liuxingbaoyu
commented
Mar 27, 2026
Comment on lines
42
to
51
| type DefineTypeOpts<T extends t.Node> = { | ||
| fields?: FieldDefinitions<T>; | ||
| fields?: FieldDefinitions<NoInfer<T>>; | ||
| visitor?: string[]; | ||
| aliases?: string[]; | ||
| builder?: string[]; | ||
| inherits?: NodeTypes; | ||
| deprecatedAlias?: string; | ||
| validate?: Validator<T>; | ||
| unionShape?: UnionShape<T>; | ||
| validate?: Validator<NoInfer<T>>; | ||
| unionShape?: UnionShape<NoInfer<T>>; | ||
| }; |
Member
Author
There was a problem hiding this comment.
Without this optimization, the check time would increase by 30 seconds.
JLHwung
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2