fix: Improve type reasoning for visitors containing |#17899
Merged
JLHwung merged 2 commits intobabel:mainfrom Apr 16, 2026
Merged
fix: Improve type reasoning for visitors containing |#17899JLHwung merged 2 commits intobabel:mainfrom
|#17899JLHwung merged 2 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61267 |
|
commit: |
liuxingbaoyu
commented
Mar 24, 2026
Comment on lines
-25
to
-34
| export type TraverseOptions<S = t.Node> = { | ||
| scope?: Scope; | ||
| noScope?: boolean; | ||
| denylist?: string[]; | ||
| shouldSkip?: (node: NodePath) => boolean; | ||
| } & Visitor<S>; | ||
|
|
||
| export type ExplodedTraverseOptions<S = t.Node> = TraverseOptions<S> & | ||
| ExplodedVisitor<S>; | ||
|
|
Member
Author
There was a problem hiding this comment.
Both of these generic types are incorrect.
ExplodedTraverseOptions also contains incorrect usage, because previously TraverseOptions included Visitor, while context#opts should only contain ExplodedVisitor.
In this PR, I adjusted TraverseOptions to not contain Visitor and removed ExplodedTraverseOptions.
Uh, I even realized that Visitor also includes ExplodedVisitor.
f384ea8 to
7b2ef55
Compare
||
||
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This resolves the issue where every
nodeA|nodeBwould be complained about by TS whenstrictFunctionTypes: true.It also provides better type reasoning.
Due to the limitations of TypeScript, this can only be implemented within function calls.