Skip to content

Add missing semicolons in 2021-12 decorators output - #14398

Merged
nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:decorators-missing-semi
Mar 28, 2022
Merged

nicolo-ribaudo merged 1 commit into
babel:mainfrom
nicolo-ribaudo:decorators-missing-semi

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Mar 28, 2022 •

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Polish 💅 A type of pull request used for our changelog categories Spec: Decorators labels Mar 28, 2022
@babel-bot

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51583/

@nicolo-ribaudo

nicolo-ribaudo commented Mar 28, 2022 •

Copy link
Copy Markdown
Member Author

@JLHwung It looks like your PR didn't fix the timeout 😕

@JLHwung

JLHwung commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

@nicolo-ribaudo Yeah, it seems that at times the watcher spend more than 2 seconds to set up. Maybe we should fallback to a polling approach.

@nicolo-ribaudo
nicolo-ribaudo merged commit 611f5c8 into babel:main Mar 28, 2022
@nicolo-ribaudo
nicolo-ribaudo deleted the decorators-missing-semi branch March 28, 2022 20:34
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 28, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories Spec: Decorators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants