Skip to content

Improve performance - #13376

Merged
existentialism merged 2 commits into
babel:mainfrom
sokra:patch-1
May 27, 2021
Merged

Improve performance#13376
existentialism merged 2 commits into
babel:mainfrom
sokra:patch-1

Conversation

@sokra

@sokra sokra commented May 26, 2021 •
edited by gitpod-io Bot
Loading

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? none
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? No
Documentation PR Link no
Any Dependency Changes? no
License MIT

O(n²) -> O(n)

@codesandbox-ci

codesandbox-ci Bot commented May 26, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c1f898:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot

babel-bot commented May 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46484/

@sokra
sokra marked this pull request as ready for review May 26, 2021 15:50
@JLHwung

JLHwung commented May 26, 2021

Copy link
Copy Markdown
Contributor

Can you rebase on main? The master is not our default branch and it is as-is so that old PRs will not be closed automatically.

@JLHwung JLHwung added the PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories label May 26, 2021
@sokra
sokra changed the base branch from master to main May 26, 2021 20:09
@sokra

sokra commented May 26, 2021

Copy link
Copy Markdown
Member Author

Can you rebase on main? The master is not our default branch and it is as-is so that old PRs will not be closed automatically.

yep, done.

JLHwung
JLHwung approved these changes May 27, 2021
View reviewed changes

@JLHwung JLHwung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism
existentialism merged commit dbfa877 into babel:main May 27, 2021
@sokra
sokra deleted the patch-1 branch May 27, 2021 10:27
@sync-by-unito sync-by-unito Bot mentioned this pull request May 31, 2021
Closed
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 27, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sokra @babel-bot @JLHwung @existentialism