Skip to content

Disallow await before exponential #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JLHwung merged 3 commits into from
Mar 25, 2021
Merged

Disallow await before exponential #12441

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d69462
refactor: move unary exponential check to parseMaybeUnary
JLHwung Nov 25, 2020
94bef1a
fix: disallow await before exponential
JLHwung Dec 2, 2020
7e186f0
add test cases
JLHwung Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: disallow await before exponential
  • Loading branch information
@JLHwung
JLHwung committed Mar 25, 2021
commit 94bef1ac78137b3a233c4297a8218304f47ded58
20 changes: 13 additions & 7 deletions packages/babel-parser/src/parser/expression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,15 @@ export default class ExpressionParser extends LValParser {
);
}

checkExponentialAfterUnary(node: N.AwaitExpression | N.UnaryExpression) {
if (this.match(tt.exponent)) {
this.raise(
node.argument.start,
Errors.UnexpectedTokenUnaryExponentiation,
);
}
}

// Parse unary operators, both prefix and postfix.
// https://tc39.es/ecma262/#prod-UnaryExpression
parseMaybeUnary(
Expand All @@ -507,7 +516,9 @@ export default class ExpressionParser extends LValParser {

if (isAwait && this.isAwaitAllowed()) {
this.next();
return this.parseAwait(startPos, startLoc);
const expr = this.parseAwait(startPos, startLoc);
if (!sawUnary) this.checkExponentialAfterUnary(expr);
return expr;
}
if (
this.isContextual("module") &&
Expand Down Expand Up @@ -543,12 +554,7 @@ export default class ExpressionParser extends LValParser {
}

if (!update) {
if (!sawUnary && this.match(tt.exponent)) {
this.raise(
node.argument.start,
Errors.UnexpectedTokenUnaryExponentiation,
);
}
if (!sawUnary) this.checkExponentialAfterUnary(node);
return this.finishNode(node, "UnaryExpression");
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-parser/src/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ export type YieldExpression = NodeBase & {

export type AwaitExpression = NodeBase & {
type: "AwaitExpression",
argument: ?Expression,
argument: Expression,

@JLHwung JLHwung Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While yield is a yield expression, await is never valid and thus the argument here can not be null.

};

export type ArrayExpression = NodeBase & {
Expand Down