Skip to content

Revert "chore: specify package type (#10849)" - #11003

Merged
nicolo-ribaudo merged 1 commit into
babel:masterfrom
nicolo-ribaudo:revert-type-commonjs
Jan 13, 2020
Merged

nicolo-ribaudo merged 1 commit into
babel:masterfrom
nicolo-ribaudo:revert-type-commonjs

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Jan 13, 2020 •

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? Fixes #11000
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)

We should re-apply the reverted commit in Babel 8.0.0.

NOTE FOR MYSELF:
When publishing, also re-publish the packages moved to babel-archive

This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)
@nicolo-ribaudo nicolo-ribaudo added i: regression PR: Revert ↩️ A type of pull request used for our changelog categories labels Jan 13, 2020
@JLHwung

JLHwung commented Jan 13, 2020

Copy link
Copy Markdown
Contributor

🤔Maybe we need npm install and yarn install in e2e-babel.

@nicolo-ribaudo

Copy link
Copy Markdown
Member Author

It wouldn't have caught it, because we don't run e2e tests with Node 6.

@nicolo-ribaudo
nicolo-ribaudo merged commit 8fce431 into babel:master Jan 13, 2020
@nicolo-ribaudo
nicolo-ribaudo deleted the revert-type-commonjs branch January 13, 2020 20:18
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 14, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Revert ↩️ A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version 7.8.0 fail to install on node 6.1.0

3 participants