This repository was archived by the owner on Aug 31, 2018. It is now read-only.
build: allow build with system python 3#97
Closed
forivall wants to merge 1 commit intoayojs:latestfrom
Closed
Conversation
When the system python is python 3, configure now creates a directory with a symlink called 'python' to python2, uses it when it calls run_gyp, and puts it in config.mk so that it propagates to everything that make launches
Contributor
|
Wouldn't it be a good idea to just cherry-pick it from upstream once it has landed there? Or include it in a normal upstream-to-downstream update? (I don't really know the policy of those updates, it just makes sense in my head.) |
Member
|
Given the number of approvals/:+1:s there, it seems to me that the patch will land in Node.js pretty soon after the ordinary 48/72-hour waiting period. When that is done, we can then include it in an ordinary pull-from-upstream. |
Contributor
Author
|
Yup, it's been merged there. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport from nodejs/node#16058
When the system python is python 3, configure now creates a directory
with a symlink called 'python' to python2, uses it when it calls
run_gyp, and puts it in config.mk so that it propagates to everything
that make launches
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build