Skip to content
This repository was archived by the owner on Aug 31, 2018. It is now read-only.

test: add basic tests for worker#114

Closed
addaleax wants to merge 1 commit intolatestfrom
workers-basic-tests
Closed

test: add basic tests for worker#114
addaleax wants to merge 1 commit intolatestfrom
workers-basic-tests

Conversation

@addaleax
Copy link
Copy Markdown
Contributor

@addaleax addaleax commented Oct 22, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test/worker

@addaleax addaleax force-pushed the workers-basic-tests branch from 68eec1f to 9bd64ba Compare October 22, 2017 20:22
@addaleax
Copy link
Copy Markdown
Contributor Author

addaleax commented Oct 24, 2017

@ayojs/core any chance I could get reviews/comments on this? :)

Qard
Qard reviewed Nov 1, 2017
View reviewed changes
Comment thread test/parallel/test-worker-dns-terminate.js

w.on('message', common.mustCall(() => {
w.terminate(common.mustCall());
}));
Copy link
Copy Markdown
Member

@Qard Qard Nov 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly is this file testing? Maybe a comment explaining why this is needed?

Copy link
Copy Markdown
Contributor Author

@addaleax addaleax Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it’s trying to tear down a worker that’s currently performing a DNS request? Just making sure nothing crashes? It’s been a few weeks since I wrote this myself, you can safely assume I know as much about the code as you do 😄

Copy link
Copy Markdown
Contributor Author

@addaleax addaleax Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I’ve added a comment here :)

@addaleax addaleax force-pushed the workers-basic-tests branch from 9bd64ba to f470c47 Compare November 2, 2017 20:49
addaleax added a commit that referenced this pull request Nov 2, 2017
@addaleax
test: add basic tests for worker
f4606e1 
PR-URL: #114
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Olivia Hugger <olivia@fastmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@addaleax
Copy link
Copy Markdown
Contributor Author

addaleax commented Nov 2, 2017

Landed in f4606e1

@addaleax addaleax closed this Nov 2, 2017
@addaleax addaleax deleted the workers-basic-tests branch November 2, 2017 23:27
addaleax added a commit to addaleax/node that referenced this pull request May 22, 2018
@addaleax
worker: initial implementation
2b42361 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117
addaleax added a commit to addaleax/node that referenced this pull request Jun 5, 2018
@addaleax
worker: initial implementation
545a873 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117
addaleax added a commit to addaleax/node that referenced this pull request Jun 5, 2018
@addaleax
worker: initial implementation
0c7012e 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117
addaleax added a commit to nodejs/node that referenced this pull request Jun 6, 2018
@addaleax
worker: initial implementation
0df031a 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117

PR-URL: #20876
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit to nodejs/node that referenced this pull request Jun 7, 2018
@addaleax @targos
worker: initial implementation
c47fcfa 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117

PR-URL: #20876
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit to nodejs/node that referenced this pull request Jun 13, 2018
@addaleax @targos
worker: initial implementation
109c92e 
Implement multi-threading support for most of the API.

Thanks to Stephen Belanger for reviewing this change in its
original form, to Olivia Hugger for reviewing the
documentation and some of the tests coming along with it,
and to Alexey Orlenko and Timothy Gu for reviewing other
parts of the tests.

Refs: ayojs/ayo#110
Refs: ayojs/ayo#114
Refs: ayojs/ayo#117

PR-URL: #20876
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@Qard Qard Qard approved these changes

@aqrln aqrln aqrln approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test worker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@addaleax @Qard @aqrln